Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Set upper bounds for MODEXP #9046

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Conversation

axic
Copy link
Member

@axic axic commented Nov 22, 2024

No description provided.

@axic axic requested a review from eth-bot as a code owner November 22, 2024 14:19
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Nov 22, 2024
EIPS/eip-modexp-limit.md Outdated Show resolved Hide resolved
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 22, 2024

✅ All reviewers have approved.

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Nov 22, 2024
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 22, 2024
EIPS/eip-modexp-limit.md Outdated Show resolved Hide resolved
@axic
Copy link
Member Author

axic commented Nov 23, 2024

@abcoathup please review again

@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 23, 2024
Copy link

The commit 58f5bfa (as a parent of a55fb0b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Nov 23, 2024
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Nov 23, 2024
@abcoathup
Copy link
Contributor

@abcoathup please review again

I'm not an EIP editor. Need to wait for one of the editors to review.

@axic
Copy link
Member Author

axic commented Nov 26, 2024

Ping @g11tech @lightclient @SamWilsn

@g11tech
Copy link
Contributor

g11tech commented Nov 26, 2024

Ping @g11tech @lightclient @SamWilsn

some nits else gtm

@axic
Copy link
Member Author

axic commented Nov 26, 2024

@g11tech done

@eth-bot eth-bot enabled auto-merge (squash) November 26, 2024 17:33
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit b16c055 into ethereum:master Nov 26, 2024
10 of 11 checks passed
@axic axic deleted the modexp-limit branch November 26, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants